8000 Keys should not consider themself for transformation. by apauzies · Pull Request #130 · go-ini/ini · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Keys should not consider themself for transformation. #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

apauzies
Copy link
Contributor
@apauzies apauzies commented Nov 13, 2017

What problem should be fixed?

NAME = ini
[package]
NAME = $(NAME)

I believe NAME in section [package] should evaluate to ini

Have you added test cases to catch the problem?

nope :/

@unknwon
Copy link
Member
unknwon commented Nov 14, 2017

Thank you!

@unknwon unknwon merged commit fa898e8 into go-ini:master Nov 14, 2017
unknwon added a commit that referenced this pull request Nov 14, 2017
@unknwon
Copy link
Member
unknwon commented Nov 14, 2017

I have added tests for you.

@apauzies
Copy link
Contributor Author

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0