Pass logger into Callback{} so that logs are printed consistently #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fad6075 to
8b12747
Compare
Codecov Report
@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
+ Coverage 80.15% 80.15% +<.01%
==========================================
Files 24 24
Lines 3431 3432 +1
==========================================
+ Hits 2750 2751 +1
Misses 578 578
Partials 103 103
Continue to review full report at Codecov.
|
|
Thanks @j16r! |
Closed
blefevre
pushed a commit
to blefevre/gorm
that referenced
this pull request
Feb 17, 2020
…-gorm#2435) Pass logger into Callback{} so that logs are printed consistently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the db's logger into Callback{} so that the same logger is used for callback registration and removal.
[Fixes #1825]