routers: do not leak secrets via timing side channel #7364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonklingele
commented
Jul 6, 2019
| @@ -771,7 +772,9 @@ func TriggerTask(ctx *context.Context) { | |||
| if ctx.Written() { | |||
| return | |||
| } | |||
| if secret != base.EncodeMD5(owner.Salt) { | |||
| 8000 | got := []byte(base.EncodeMD5(owner.Salt)) | ||
There was a problem hiding this comment.
Why does this
- use md5?
- use owner's salt instead of some secret?
And who calls this API? Couldn't find any callers inside gitea itself.
zeripath
approved these changes
Jul 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #7364 +/- ##
==========================================
+ Coverage 41.24% 41.25% +<.01%
==========================================
Files 467 467
Lines 63291 63295 +4
==========================================
+ Hits 26107 26111 +4
+ Misses 33769 33768 -1
- Partials 3415 3416 +1
Continue to review full report at Codecov.
|
lunny
approved these changes
Jul 6, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* routers: do not leak secrets via timing side channel * routers/repo: do not leak secrets via timing side channel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.