Fix Erlang and Elixir highlight mappings #7044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please reformat ( |
|
Done. A friend also made me aware that hightlight.js has an "erl" alias for erlang, so that one could be moved up to the upper mapping. The three other are less lucky. Would you prefer that? |
Codecov Report
@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
- Coverage 41.72% 41.72% -0.01%
==========================================
Files 443 443
Lines 60149 60149
==========================================
- Hits 25099 25097 -2
- Misses 31774 31776 +2
Partials 3276 3276
Continue to review full report at Codecov.
|
|
Yes please move erl up if it works with our used version |
|
Moved ".erl" up to be in the same place as ".erlang" was before. Not sure what the ordering is. Tested with the shipped highlight.js - works as expected. |
lafriks
approved these changes
May 28, 2019
adelowo
approved these changes
May 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Without these changes, the highlighting language determination for both Erlang (.erl, .escript) and Elixir (.ex, .exs) files is left up to a dice roll -- sometimes it is typescript, some other times actionscript. Exciting.
I do not believe ".erlang" and ".elixir" to be extensions used wildly in the wild.
I realize this replaces a single entry with two for each of the languages, and .escript is not even that common and could be left out.
Thanks.