8000 Comments on migrated issues/prs must link to the comment ID by singuliere · Pull Request #18630 · go-gitea/gitea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Comments on migrated issues/prs must link to the comment ID #18630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2022
Merged

Comments on migrated issues/prs must link to the comment ID #18630

merged 3 commits into from
Feb 6, 2022

Conversation

singuliere
Copy link
Contributor
@singuliere singuliere commented Feb 5, 2022 •
edited
Loading

Instead of the issue ID which is not a valid anchor.

image

@singuliere
comments on migrated issues/prs must link to the comment ID
05c57ea 
Instead of the issue ID which is not a valid anchor.

Signed-off-by: singuliere <singuliere@autistici.org>
@singuliere singuliere added type/bug topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Feb 5, 2022
@singuliere singuliere added this to the 1.17.0 milestone Feb 5, 2022
@singuliere singuliere requested a review from lunny February 5, 2022 23:03
@codecov-commenter
Copy link
codecov-commenter commented Feb 5, 2022 •
edited
Loading

Codecov Report

Merging #18630 (b6f833e) into main (8bd89ca) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18630      +/-   ##
==========================================
+ Coverage   46.28%   46.30%   +0.01%     
==========================================
  Files         846      846              
  Lines      121236   121236              
==========================================
+ Hits        56119    56141      +22     
+ Misses      58303    58279      -24     
- Partials     6814     6816       +2
Impacted Files Coverage Δ
models/repo_list.go 75.66% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 39.78% <0.00%> (+0.15%) ⬆️
routers/web/repo/view.go 39.52% <0.00%> (+0.50%) ⬆️
modules/queue/workerpool.go 56.98% <0.00%> (+1.11%) ⬆️
models/unit/unit.go 48.67% <0.00%> (+1.76%) ⬆️
modules/queue/queue_bytefifo.go 52.39% <0.00%> (+4.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd89ca...b6f833e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2022
@singuliere singuliere mentioned this pull request Feb 6, 2022
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Feb 6, 2022
@zeripath zeripath merged commit ce8eb20 into go-gitea:main Feb 6, 2022
@zeripath zeripath changed the title comments on migrated issues/prs must link to the comment ID Comments on migrated issues/prs must link to the comment ID Feb 6, 2022
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@singuliere
comments on migrated issues/prs must link to the comment ID (go-gitea…
ae6fd01 
…#18630)

Instead of the issue ID which is not a valid anchor.

Signed-off-by: singuliere <singuliere@autistici.org>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@singuliere @codecov-commenter @lunny @zeripath @GiteaBot
0