Ignore files in diff with check-attr #16262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16262 +/- ##
==========================================
+ Coverage 44.24% 45.48% +1.24%
==========================================
Files 695 709 +14
Lines 82341 83456 +1115
==========================================
+ Hits 36429 37960 +1531
+ Misses 40014 39420 -594
- Partials 5898 6076 +178
Continue to review full report at Codecov.
|
|
I think it should also set IsGenerated by using go-enry method IsGenerated |
|
Is it really necessary to sync |
zeripath
added a commit
that referenced
this pull request
Sep 9, 2021
…guage stats and diffs (#16773) Replaces #16262 Replaces #16250 Replaces #14833 This PR first implements a `git check-attr` pipe reader - using `git check-attr --stdin -z --cached` - taking account of the change in the output format in git 1.8.5 and creates a helper function to read a tree into a temporary index file for that pipe reader. It then wires this in to the language stats helper and into the git diff generation. Files which are marked generated will be folded by default. Fixes #14786 Fixes #12653
|
@zeripath close? |
|
yeah I think this has been replaced. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12653
close #16250
This PR moves the
.gitattributefile from the root of the default branch intorepo.git/info/attributesafter every push. The diff supports now thelinguist-generatedkeyword and hides these file in the output.