Make mirror feature more configurable #16957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16957 +/- ##
=======================================
Coverage ? 45.14%
=======================================
Files ? 764
Lines ? 86282
Branches ? 0
=======================================
Hits ? 38956
Misses ? 41020
Partials ? 6306
Continue to review full report at Codecov.
|
zeripath
reviewed
Sep 5, 2021
zeripath
reviewed
Sep 5, 2021
|
Please put better explanations as to what the PR is supposed to be doing in the first comment of the PR. |
zeripath
reviewed
Sep 5, 2021
|
minor nits only. |
41b966c to
00db6ff
Compare
@zeripath |
zeripath
approved these changes
Sep 5, 2021
lunny
reviewed
Sep 6, 2021
zeripath
reviewed
Sep 6, 2021
zeripath
reviewed
Sep 6, 2021
|
Ref: #11740 |
Co-authored-by: zeripath <art27@cantab.net>
|
resolve #11740 (comment) too ... |
delvh
approved these changes
Sep 6, 2021
6543
commented
Sep 6, 2021
Co-authored-by: delvh <dev.lh@web.de>
lunny
approved these changes
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
[repository]DISABLE_MIRRORSto[mirror]DISABLE_NEW_PULLand addENABLEDandDISABLE_NEW_PUSHwith the below meanings:ENABLED: true: Enables the mirror functionality. Set to false to disable all mirrors.DISABLE_NEW_PULL: false: Disable the creation of new mirrors. Pre-existing mirrors remain valid.DISABLE_NEW_PUSH: false: Disable the creation of new push mirrors. Pre-existing mirrors remain valid.🚫 DEPRECATION 🚫
This PR deprecates the
[repository]DISABLE_MIRRORSsetting - which is mapped to[mirror]DISABLE_NEW_PULL.