-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Make API EditIssue and EditPullRequest issue notifications #11123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API EditIssue and EditPullRequest issue notifications #11123
Conversation
Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest to issue notifications Fix go-gitea#10014 Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath thanks for taking care of this issue it got out of my eyes |
Please resolve the conflicts. |
…eTitleChangedCommit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think my comments are relevant, but they are issues of style and not really blockers; otherwise looks good 👍
Codecov Report
@@ Coverage Diff @@
## master #11123 +/- ##
==========================================
+ Coverage 43.97% 43.98% +0.01%
==========================================
Files 613 613
Lines 87333 87371 +38
==========================================
+ Hits 38404 38431 +27
- Misses 44200 44208 +8
- Partials 4729 4732 +3
Continue to review full report at Codecov.
|
…11123) * Make API EditIssue and EditPullRequest issue notifications Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest to issue notifications Fix go-gitea#10014 Signed-off-by: Andrew Thornton <art27@cantab.net> * As per @6543 Signed-off-by: Andrew Thornton <art27@cantab.net> * update status! Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv>
Restructure models.UpdateIssueByAPI and EditIssue/EditPullRequest to issue notifications
Fix #10014
Signed-off-by: Andrew Thornton art27@cantab.net