8000 Stop hanging issue indexer initialisation from preventing shutdown by zeripath · Pull Request #10243 · go-gitea/gitea · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Stop hanging issue indexer initialisation from preventing shutdown #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2020
Merged

Stop hanging issue indexer initialisation from preventing shutdown #10243

8000
merged 3 commits into from
Feb 11, 2020

Conversation

zeripath
Copy link
Contributor

If the issue indexer hangs during initialisation and times out previously this code would prevent the shutdown of Gitea.

This code moves the initialisation out of a graceful RunWithShutdown().

@zeripath zeripath added this to the 1.12.0 milestone Feb 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 11, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 11, 2020
@codecov-io
Copy link
codecov-io commented Feb 11, 2020 •
edited
Loading

Codecov Report

Merging #10243 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10243      +/-   ##
==========================================
- Coverage    43.7%   43.66%   -0.04%     
==========================================
  Files         582      582              
  Lines       80047    80047              
==========================================
- Hits        34983    34953      -30     
- Misses      40732    40758      +26     
- Partials     4332     4336       +4
Impacted Files Coverage Δ
services/pull/check.go 31.09% <0%> (-7.32%) ⬇️
services/pull/temp_repo.go 29.05% <0%> (-5.13%) ⬇️
services/pull/patch.go 60.37% <0%> (-2.52%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
models/error.go 30.4% <0%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60e082...90a5ec1. Read the comment docs.

@sapk sapk merged commit 1125d14 into go-gitea:master Feb 11, 2020
@sapk
Copy link
Member
sapk commented Feb 11, 2020

Please send backport

@zeripath zeripath deleted the ensure-issue-index-timeout-can-finish branch February 12, 2020 08:44
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 12, 2020
@zeripath @lafriks @sapk
Stop hanging issue indexer initialisation from preventing shutdown (g…
a10d8a5 
…o-gitea#10243)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@zeripath zeripath mentioned this pull request Feb 12, 2020
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Feb 12, 2020
lafriks added a commit that referenced this pull request Feb 12, 2020
@zeripath @lafriks @sapk
Stop hanging issue indexer initialisation from preventing shutdown (#…
5cdfde2 
…10243) (#10249)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jaqra jaqra jaqra approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @codecov-io @sapk @lafriks @jaqra @GiteaBot
0