8000 added a leaderboard by PhilippHerud · Pull Request #23 · go-cat/go-cat · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

added a leaderboard #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added a leaderboard #23

wants to merge 1 commit into from

Conversation

PhilippHerud
Copy link

Hi,
i added a leaderboard for go-cat, you just need to change the config.php and create a database in phpmyadmin with the gocat.sql.
Have a nice day!

@ThomasChr
Copy link
Contributor

Hi @PhilippHerud !
Thanks for the reminder yesterday.

We've seen this Pull Request and we're very flattered - but there are a few things wrong with it.
The main problem being that you can never make a public scoreboard save. You can't defend it from wrong scores sent directly to it, and you can't defend it from thousands of irrelevant scores (believe me, we've tried that).
So we've decided to not add a public scoreboard to any game.
You can make it a little more complicated by sending a secret token with every score (I think we've done that), but as an open source project you need to at least add the token in the pipeline. And everyone who downloads the release can read that out of the source code.

Oh, and your PR seems to work just fine, but there is a bad SQL Injection in it. You should use prepared statements in all cases.

I hope that makes our intentions clear and again thanks a lot for this PR, we really appreciate that!

PS: If you, or some of your pupils, want to try out a game engine which doesn't need any coding (you click the if's and else's) then you should try the engine "GB Studio" and maybe add some code to our game bubblequack: https://github.com/bubblequack/bubblequack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippHerud @ThomasChr
0