Mojave / Catalina support #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of XPC services with the "cbgo" library (CoreBluetooth Go).
|
This is very exciting contribution, and I look forward to testing it out. Thanks for working on it @ccollins476ad |
This fixes what seems to be a Catalina-specific issue. Pre-Catalina: The DidUpdateState delegate callbacks get called *after* the delegate properties gets assigned. Catalina: DidUpdateState gets called immediately upon construction of the manager objects (CBCentralManager and CBPeripheralManager). Prior to this commit, the code assumed it could assign the delegate properties and then listen for the transition to the powered-on state. This works for older versions of macOS, but with Catalina the code blocks forever, waiting for an event that has already occurred. The fix is to use the following procedure: (for each manager object): 1. Assign the delegate. 2. Check the state. If the state is not "unknown" then the procedure is done. 3. Else, wait up to one second for a state change event.
+1 I'm currently using the https://github.com/JuulLabs-OSS/ble fork on macOS Catalina. |
|
Any updates here? This would be great to merge. |
|
Apologies for the long delay in responding to this PR. This work looks good. I'm not easily able to test it but I'm happy to merge it based on the feedback I have seen thus far on the PR and issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of XPC services with the "cbgo" library
(CoreBluetooth Go). This PR consists of a single massive commit and for that I apologize.
The cbgo library (https://github.com/JuulLabs-OSS/cbgo) is new and likely buggy. As the README indicates, there are definitely memory leaks that will need to be fixed. That said, I have tested this PR with the go-ble example apps and the newtmgr tool (https://github.com/apache/mynewt-newtmgr) without issue.