8000 Make the *darwin.Device implement the ble.DeviceOption interface by peterhellberg · Pull Request #63 · go-ble/ble · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make the *darwin.Device implement the ble.DeviceOption interface #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

Make the *darwin.Device implement the ble.DeviceOption interface #63

merged 1 commit into from
Apr 7, 2020

Conversation

peterhellberg
Copy link
  • Add SetConnectedHandler and SetDisconnectedHandler to *darwin.Device

Related to issue: #59

This change only allows the code to compile, not to actually work.

@peterhellberg
Copy link
Author

Not sure why codebeat is marking this as pending, can I do anything to resolve this?

@cusspvz
Copy link
cusspvz commented Apr 5, 2020 •
edited
Loading

This should get merged before anyone actually implements those methods since it blocks any build due to a type mismatch error:

# github.com/go-ble/ble/darwin
../../../go/pkg/mod/github.com/go-ble/ble@v0.0.0-20200120171844-0a73a9da88eb/darwin/device.go:67:12: cannot use d (type *Device) as type ble.DeviceOption in argument to opt:
        *Device does not implement ble.DeviceOption (missing SetConnectedHandler method)

@peterhellberg
Copy link
Author

@estutzenberger Is this PR ready to be merged or do I need to do something about the codebeat warning?

@estutzenberger
Copy link

Nah. I'm not worried about it. Sorry for the delay!

@estutzenberger estutzenberger merged commit 067514c into go-ble:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterhellberg @cusspvz @estutzenberger
0