Make Document and Decoration serializables #312
Conversation
| try { | ||
| return Color.web(color); | ||
| } catch (Exception e) { | ||
| return defaultColor; |
There was a problem hiding this comment.
Shouldn't a log entry explain here what was being parsed? I can imagine users wondering why they select RED and are returned with the defaultColor.
There was a problem hiding this comment.
Color::web admits different formats for colours, like "#ff0000" or "0xff0000" or red or rgb(255,0,0), (see https://github.com/openjdk/jfx/blob/master/modules/javafx.graphics/src/main/java/javafx/scene/paint/Color.java#L288).
But if there are typos or not valid strings, like unknown colours, there would be an IllegalArgumentException exception, and that would be avoided by using a default colour.
|
Looks good, 1 remark. |
Fixes #297