Add support for drag and drop #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While drag-dropping a hyperlink in between 2 words, the previous word seems to be always selected before the hyperlink is pasted resulting in the first word becoming a hyperlink. This might not always be the desired result. |
|
What do you propose in that case? |
|
The link should be pasted as it is between the two words? |
|
@jperedadnr I don't mind :-) |
abhinayagarwal
previously approved these changes
Apr 7, 2022
johanvos
approved these changes
Apr 7, 2022
abhinayagarwal
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
@dlemmermann I've started reviewing your PR #142 , but since it required many changes, I ended up doing a new PR, with some extra features (like image checks, hyperlink and caret movement), if you don't mind.