8000 Add default paragraph graphic factory by jperedadnr · Pull Request #156 · gluonhq/rich-text-area · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add default paragraph graphic factory #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 6, 2022
Merged

Add default paragraph graphic factory #156

merged 5 commits into from
Apr 6, 2022

Conversation

jperedadnr
Copy link
Collaborator
@jperedadnr jperedadnr commented Apr 5, 2022 •
edited
Loading

Fixes #151
Fixes #152

abhinayagarwal
abhinayagarwal reviewed Apr 5, 2022
View reviewed changes
@abhinayagarwal
Copy link
Collaborator

Some more findings:

  • It is not possible to remove a bullet by toggling off the button
  • Pressing backspace on the start of the bullet should only remove the bullet. Currently, it moves to previous paragraph.

@jperedadnr
Copy link
Collaborator Author

Right, I can reproduce both.
First issue should be easy to fix.
The backspace one might be harder.

dlemmermann
dlemmermann reviewed Apr 5, 2022
View reviewed changes
pom.xml Outdated
@@ -94,6 +94,9 @@
<version>${javafx.plugin.version}</version>
<configuration>
<mainClass>${main.class}</mainClass>
<options>
<option>--add-exports=javafx.graphics/com.sun.javafx.tk=ALL-UNNAMED</option>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this please be turned into a motivation to move some of that API into the public area?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but you know how it goes, making public exiting private API is challenging to say the least...
For instance, demand for public FontMetrics dates back to 2010... https://bugs.openjdk.java.net/browse/JDK-8090775
The last comment about using the old com/sun/javafx/scene/control/skin/Utils.java gave me an idea, and I've been able to remove the private API...

dlemmermann
dlemmermann previously approved these changes Apr 5, 2022
View reviewed changes
@jperedadnr
Copy link
Collaborator Author

@abhinayagarwal I've addressed your comments, PR is ready for review again.

abhinayagarwal
abhinayagarwal approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator
@abhinayagarwal abhinayagarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bullet numbers do not follow the font family/size of the paragraph it is applied to. Although, the fix may be for a separate PR.

@jperedadnr
Copy link
Collaborator Author

Numbers do use the same font size, but not font family (following NotesApp for instance). This can be discussed in a follow-up issue.

@jperedadnr jperedadnr merged commit 1605d60 into gluonhq:master Apr 6, 2022
@jperedadnr jperedadnr deleted the 151-lists branch April 6, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinayagarwal abhinayagarwal abhinayagarwal approved these changes

@dlemmermann dlemmermann dlemmermann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numbers and bullets alignment and layout issues. Lists do not show numbers or bullets
3 participants
@jperedadnr @abhinayagarwal @dlemmermann
0