8000 fix "Setctty set but Ctty not valid in child" problem in pty example by muryliang · Pull Request #139 · gliderlabs/ssh · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix "Setctty set but Ctty not valid in child" problem in pty example #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

fix "Setctty set but Ctty not valid in child" problem in pty example #139

merged 1 commit into from
Feb 16, 2021

Conversation

muryliang
Copy link
Contributor

problem occurred in go1.15 and upstream creack/pty#96

@r10r
Copy link
8000 r10r commented Feb 16, 2021

Kindly ping @gliderlabs devs. Please merge this small change. I've had the same issue with the pty example.

shazow
shazow approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member
@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@belak belak merged commit 30ec06d into gliderlabs:master Feb 16, 2021
@belak
Copy link
Collaborator
belak commented Feb 16, 2021

Thanks for submitting this! It's been merged.

Sorry about the squash - I was hoping the mobile app would let me specify a commit message on squash like the web UI does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazow shazow shazow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muryliang @r10r @belak @shazow
0