8000 Make AddFinding public by bplaxco · Pull Request #1767 · gitleaks/gitleaks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make AddFinding public #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privac 8000 y statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

Make AddFinding public #1767

merged 1 commit into from
Feb 24, 2025

Conversation

bplaxco
Copy link
Contributor
@bplaxco bplaxco commented Feb 21, 2025 •
edited
Loading

Description:

To allow other tools using d.Detect() to leverage the code in AddFinding

Changes:

  • Rename d.addFinding -> d.AddFinding
  • Add d.Findings()

My use case: https://github.com/leaktk/scanner/pull/107/files#diff-f8472fe0bafccc33f268c74d1bd2a697594914d4e1d796805b254249cbc78828R175-R182

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes? (N/A)
  • Have you lint your code locally prior to submission?

cc: @zricethezav && @rgmz

@bplaxco
Make AddFindings public
0847437 
- Rename d.addFindings -> d.AddFindings
- Add d.Findings()

To allow other tools using d.Detect() to leverage the code in
AddFindings
@bplaxco bplaxco changed the title Make AddFindings public Make AddFinding public Feb 21, 2025
@bplaxco bplaxco mentioned this pull request Feb 21, 2025
Merged
rgmz
rgmz approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor
@rgmz rgmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zricethezav zricethezav merged commit f6a7439 into gitleaks:master Feb 24, 2025
2 checks passed
@bplaxco bplaxco deleted the pub-add-findings branch April 15, 2025 22:51
sirakav pushed a commit to sirakav/gitleaks that referenced this pull request Apr 25, 2025
@bplaxco
Make AddFindings public (gitleaks#1767)
3b93349 
- Rename d.addFindings -> d.AddFindings
- Add d.Findings()

To allow other tools using d.Detect() to leverage the code in
AddFindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

@rgmz rgmz rgmz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bplaxco @zricethezav @rgmz
0