8000 chore(gcp): add firebase example keys to the gcp-api-key allowlists by bufferoverflow · Pull Request #1635 · gitleaks/gitleaks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(gcp): add firebase example keys to the gcp-api-key allowlists #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

chore(gcp): add firebase example keys to the gcp-api-key allowlists #1635

merged 1 commit into from
Jan 15, 2025

Conversation

bufferoverflow
Copy link
Contributor
@bufferoverflow bufferoverflow commented Nov 13, 2024 •
edited
Loading

Description:

The firebase-android-sdk contains some example keys. This PR adds them to the allowlists for the gcp-api-key.

before

gitleaks git /tmp/firebase-android-sdk/ --enable-rule gcp-api-key

    ○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

10:02AM INF Overriding enabled rules: gcp-api-key
10:03AM INF 5948 commits scanned.
10:03AM INF scan completed in 18.7s
10:03AM WRN leaks found: 91

after

./gitleaks git /tmp/firebase-android-sdk/ --enable-rule gcp-api-key

    ○
    │╲
    │ ○
    ○ ░
    ░    gitleaks

10:02AM INF Overriding enabled rules: gcp-api-key
10:03AM INF 5948 commits scanned.
10:03AM INF scanned ~93888297 bytes (93.89 MB) in 17.9s
10:03AM INF no leaks found

Checklist:

  • Does your PR pass tests?
  • Have you written new tests for your changes?
  • Have you lint your code locally prior to submission?

@zricethezav
Copy link
Collaborator

@bufferoverflow sorry for the delayed review, these changes look good to me. Would you mind fixing the conflicts then I'd be happy to merge.

@bufferoverflow bufferoverflow force-pushed the chore/add-firebase-to-gcp-allow-list branch from 7657ea5 to 1184374 Compare January 15, 2025 08:52
@bufferoverflow bufferoverflow force-pushed the chore/add-firebase-to-gcp-allow-list branch from 1184374 to 2689a50 Compare January 15, 2025 09:02
@bufferoverflow
Copy link
Contributor Author

@zricethezav Thanks! I just rebased locally.

@zricethezav zricethezav merged commit 7bad9f7 into gitleaks:master Jan 15, 2025
1 check passed
Sign up for free to join this conve 5D5D rsation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bufferoverflow @zricethezav
0