8000 Add support for MariaDB connection in configuration and URI generation by Vasanth-96 · Pull Request #1552 · github/gh-ost · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for MariaDB connection in configuration and URI generation #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for MariaDB connection in configuration and URI generation #1552

wants to merge 1 commit into from
+25 −1

Conversation

Vasanth-96
Copy link
@Vasanth-96 Vasanth-96 commented May 6, 2025 •
edited
Loading

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #1488
#1488

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR addresses the issue encountered with MariaDB 10.3 when running gh-ost version 1.1.7. The error occurs due to the use of the transaction_isolation system variable, which is not present in MariaDB 10.3. Instead, MariaDB 10.3 uses tx_isolation to configure the transaction isolation level.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

attaching the images
image
image

@Vasanth-96
Copy link
Author

HI @rashiq @meiji163 @timvaillancourt could you guys review this pr and let me know if any more fix/changes need!
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashiq rashiq Awaiting requested review from rashiq rashiq is a code owner

@meiji163 meiji163 Awaiting requested review from meiji163 meiji163 is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

36DA
2 participants
@Vasanth-96 @vasanth-itilite
0