8000 Refactor CI workflow for linting and building steps by chrisreddington · Pull Request #3 · github-samples/gh-game · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor CI workflow for linting and building steps #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicki 8000 ng “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

chrisreddington
Copy link
Contributor

Separate linting and building steps in the CI workflow and utilize an environment variable for the Go version. This improves clarity and maintainability of the CI process.

@Copilot Copilot AI review requested due to automatic review settings May 9, 2025 15:37
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the CI workflow by splitting linting and build/test into separate jobs and centralizing the Go version in an environment variable.

  • Introduce a top-level GO_VERSION env var for the Go version
  • Create a dedicated lint job and a separate build-and-test job
  • Update all actions/setup-go steps to use ${{ env.GO_VERSION }}
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:61

  • The Test step is still indented under the original job and not inside the new build-and-test job's steps. Move and re-indent it under build-and-test so that tests run as part of the build/test job.
- name: Test

@chrisreddington chrisreddington merged commit 26142bd into main May 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0