Grants - v0.2 soft launch #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o ks_miner_fixes
…rong with cancel_grant_tx_id
Ks approve fix
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
=========================================
- Coverage 30.13% 30.1% -0.04%
=========================================
Files 193 193
Lines 14533 14568 +35
Branches 1900 1906 +6
=========================================
+ Hits 4380 4386 +6
- Misses 10015 10044 +29
Partials 138 138
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3239 +/- ##
=========================================
- Coverage 30.13% 30.1% -0.03%
=========================================
Files 193 193
Lines 14533 14570 +37
Branches 1900 1907 +7
=========================================
+ Hits 4380 4387 +7
- Misses 10015 10045 +30
Partials 138 138
Continue to review full report at Codecov.
|
…o single quote in comiledSubscriptionToken
…token_symbol changes
…token_symbol changes
Grants/details: Add gas settings on cancel grants
…o grantz-cleanup
owocki
reviewed
Dec 19, 2018
| contract_owner_address | ||
| ).send({ | ||
| from: accounts[0], | ||
| gasPrice: 8000000000 |
There was a problem hiding this comment.
gas price should not be hardcoded -- why not web3.utils.toHex($('#gasPrice').val() * Math.pow(10, 9) ?
There was a problem hiding this comment.
Need to add gasSettings to owner change as well.
owocki
reviewed
Dec 19, 2018
| @@ -22,6 +22,12 @@ var gas_amount = function(page_url) { | |||
| gasLimitEstimate = 21000; | |||
| } else if (page_url.indexOf('tip/receive') != -1) { // tip | |||
| gasLimitEstimate = 21000; | |||
| } else if (page_url.indexOf('/fund') != -1) { // grant contribution | |||
| gasLimitEstimate = 318730; | |||
There was a problem hiding this comment.
funding / creating a new subscription cost the same gas-wise? that doesnt seem right
owocki
reviewed
Dec 19, 2018
| <script src="{% static "v2/js/abi.js" %}"></script> | ||
| <script src="/dynamic/js/tokens_dynamic.js"></script> | ||
| <script src="{% static "v2/js/tokens.js" %}"></script> | ||
| <script src="{% static "v2/js/shared.js" %}"></script> | ||
| <script src="{% static "v2/js/ipfs-api.js" %}"></script> | ||
| <script src="{% static "v2/js/ipfs.js" %}"></script> | ||
| <script type="text/javascript" src="https://cdn.jsdelivr.net/momentjs/latest/moment.min.js"></script> | ||
| <script type="text/javascript" src="https://cdn.jsdelivr.net/npm/daterangepicker/daterangepicker.min.js"></script> |
There was a problem hiding this comment.
can we host these locally instead of using an external CDN?
owocki
reviewed
Dec 19, 2018
| <div class="progressbar"> | ||
| <div class="progress-completed" style="width: {{ grant.percentage_done|floatformat:0 }}%;"> | ||
| </div> | ||
| <!-- #TODO - Change object that takes the percentage value of removed contribution. --> |
owocki
reviewed
Dec 19, 2018
captnseagraves
approved these changes
Dec 19, 2018
|
Looks like we missed this: #3239 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to get grants closer to being ready for public consumption.
Checklist
Affected core subsystem(s)
Refers/Fixes
Testing and Sign-off
Contributor
make testand everything passed!Reviewer
Funder