8000 This should load the sendgrid API key from the GH secrets when runnin… by nutrina · Pull Request #10995 · gitcoinco/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

This should load the sendgrid API key from the GH secrets when runnin… #10995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

This should load the sendgrid API key from the GH secrets when runnin… #10995

merged 1 commit into from
Jan 9, 2023

Conversation

nutrina
Copy link
Contributor
@nutrina nutrina commented Jan 9, 2023

…g the deploy step

Description

Load the sendgrid API key from secrets when deploying.

Refers/Fixes

https://discord.com/channels/562828676480237578/1051989887122944050

Testing

vacekj
vacekj approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor
@vacekj vacekj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vacekj vacekj merged commit 388d182 into master Jan 9, 2023
@vacekj vacekj deleted the sendgrid_key_in_new_env branch January 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kammerdiener kammerdiener kammerdiener approved these changes

@vacekj vacekj vacekj approved these changes

@thelostone-mc thelostone-mc Awaiting requested review from thelostone-mc

@chibie chibie Awaiting requested review from chibie

@tim-schultz tim-schultz Awaiting requested review from tim-schultz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nutrina @kammerdiener @vacekj
0