Changed tab to space conversion #1065
Conversation
Tabs are not always 4 spaces large. It completes the line to the 4th character.
|
You can see the result here: |
| } else { | ||
| retStr.append(inStr.charAt(i)); | ||
| } | ||
|
|
||
| l = (l + 1) % tabLength; | ||
| if (inStr.charAt(i) == '\n') |
There was a problem hiding this comment.
Would you wrap this if with curly braces?
|
This looks like a nice fix. Could you write a unit test or two to verify that it works like expected so in the future we don't accidentally break your improvement? |
|
No problem. I'll do this on sunday ! Do you see a way to implement this ? Would testing a tab for let's say, the 50 first positions be enough ? De : James Moger notifications@github.com This looks like a nice fix. Could you write a unit test or two to verify that it works like expected so in the future we don't accidentally break your improvement? You are receiving this because you modified the open/close state. |
|
I've added a simple tab->space conversion testing. |
|
Hello, Dou you plan to merge this for the 1.8.0 release ? Thanks ! |
The contribution branch was rebased to current master. This should close gitblit-org#1065 as merged.
|
Closed as merged. |
Tabs are not always 4 spaces large. It completes the line to the 4th
character.