8000 branch: don't delete remote branches with -d/-D by jamiew · Pull Request #89 · git-friendly/git-friendly · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

branch: don't delete remote branches with -d/-D #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on G 8000 itHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

branch: don't delete remote branches with -d/-D #89

merged 1 commit into from
Apr 17, 2020

Conversation

jamiew
Copy link
Collaborator
@jamiew jamiew commented Apr 17, 2020 •
edited
Loading

Removes ability to delete branches at all. This is unexpected behavior

I accidentally deleted a remote branch and closed a PR due to this issue: helpwithcovid/covid-volunteers#167 (comment)

@sapegin if you don't object I'll issue a new version with the fix

Fixes #88

@jamiew jamiew changed the title branch: don't delete remote branches branch: don't delete remote branches with -d/-D Apr 17, 2020
sapegin
sapegin approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator
@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@jamiew jamiew merged commit 45a3d30 into master Apr 17, 2020
@jamiew
Copy link
Collaborator Author
jamiew commented Apr 17, 2020 •
edited
Loading

Released v1.0.1 and then promptly released v1.0.2 because I had a typo in this PR :(

1.0.1 https://github.com/git-friendly/git-friendly/releases/tag/1.0.1

1.0.2 https://github.com/git-friendly/git-friendly/releases/tag/1.0.2

p.s. releasing new version is a bit of a pain, here's my steps. Ideas on streamlining welcome...

  • Used GitHub web interface to tag a release on this repo, and wrote a quick changelog of changes and merged PRs since last release
  • Manually download new .tar.gz file, run shasum -a 256 on it
  • Edit homebrew-git-friendly/git-friendly.rb and update version, url, and sha256
  • Push update to homebrew-git-friendly (didn't bother using a PR)
  • Run brew upgrade git-friendly to make sure it worked

@sapegin
Copy link
Collaborator
sapegin commented Apr 27, 2020

I guess we can write a script to do all except the first item?

@jamiew jamiew deleted the branch-should-not-delete-remote branch October 12, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

branch: -d unexpectedly deletes remote branches
2 participants
@jamiew @sapegin
0