8000 Implement upvote toggle by laymonage · Pull Request #18 · giscus/giscus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Implement upvote toggle #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2021
Merged

Implement upvote toggle #18

merged 3 commits into from
May 9, 2021

Conversation

laymonage
Copy link
Member
@laymonage laymonage commented Apr 17, 2021 •
edited
Loading

This PR should implement the upvote toggle functionality ("fix" #31). However, for some reason, GitHub's API returns "Resource not accessible by integration" for addUpvote and removeUpvote mutations when using app-issued token. Using PAT works fine.

@vercel
Copy link
vercel bot commented Apr 17, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/laymonage/giscussions/E6YtN7C1Z1C14ijtYsyMFQ612pTo
✅ Preview: https://giscussions-git-upvotes-laymonage.vercel.app

@laymonage
Copy link
Member Author

Update: I've tried enabling ALL permissions on the app but I still get FORBIDDEN errors when trying to add/remove upvotes. Looks like this needs to be resolved from GitHub's side.

@laymonage laymonage mentioned this pull request May 5, 2021
Open
@laymonage
Copy link
Member Author

I guess we should just merge this and see if GitHub will fix this.

@laymonage laymonage merged commit 67ba05c into main May 9, 2021
@laymonage laymonage deleted the upvotes branch May 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@laymonage
0