8000 Embedded frame redirects 307 https://github.com/orgs/giscus/discussions/1298 for new script tag from giscus.app · Issue #1356 · giscus/giscus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Embedded frame redirects 307 https://github.com/orgs/giscus/discussions/1298 for new script tag from giscus.app #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niccokunzmann opened this issue Apr 14, 2024 · 2 comments
Open

Embedded frame redirects 307 https://github.com/orgs/giscus/discussions/1298 for new script tag from giscus.app #1356

niccokunzmann opened this issue Apr 14, 2024 · 2 comments

Comments

@niccokunzmann
Copy link

I copied the script from the giscus.app website.
When I embed the script, I can see this redirect.

307
location: https://github.com/orgs/giscus/discussions/1298

So, no comments appear but the discussion claims that I use the giscus repository. I wonder why because I do not use it.

grafik

Resulting script:

<script src="https://giscus.app/client.js"
        data-repo="niccokunzmann/open-web-calendar"
        data-repo-id="MDEwOlJlcG9zaXRvcnkxNzA4ODYyNzY="
        data-category="General"
        data-category-id="DIC_kwDOCi-EhM4CX3Pe"
        data-mapping="og:title"
        data-strict="0"
        data-reactions-enabled="1"
        data-emit-metadata="0"
        data-input-position="top"
        data-theme="noborder_light"
        data-lang="en"
        crossorigin="anonymous"
        async>
</script>

Context: #1348
niccokunzmann added a commit to niccokunzmann/open-web-calendar that referenced this issue Apr 14, 2024
@niccokunzmann
removing origins
bb3acf7 
Test to see if giscus/giscus#1356 works after this
@niccokunzmann
Copy link
Author
niccokunzmann commented Apr 14, 2024 •
edited
Loading

If you have a look at the commit above, you can see that I removed the origins value.
It seems that this value was causing the redirect.

It works now:

grafik

So, redirecting when the origins value is the problem, is misleading. Would it be possible to display a page saying:

This URL is forbidden to comment on the repository niccokunzmann/open-web-calendar because the giscus.json file does not contain "..." in the 'origins' list.

I think that text would solve the issue for me!

niccokunzmann added a commit to niccokunzmann/open-web-calendar that referenced this issue Apr 14, 2024
@niccokunzmann
add origins again
7c3a7a6 
see giscus/giscus#1356
@giggio
Copy link
giggio commented Feb 28, 2025

Agreed, this is misleading. I just fell for it, there should be a better response to help the user find the real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giggio @niccokunzmann
0