-
Notifications
You must be signed in to change notification settings - Fork 3
feat(GiniInternalPaymentSDK): Landscape mode screens HealthSDK #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
razvancapra
wants to merge
40
commits into
main
Choose a base branch
from
GiniInternalPaymentSDK-landscape
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ other fixes IPC-468
…ng edge case IPC-481
… is installed IPC-474
… PaymentReviewContainer IPC-478
8000
Great job here, I tested again and now is working fine. |
lestergini
approved these changes
Mar 31, 2025
…reen IPC-478
…et and review screen IPC-656
…g with keyboard opened IPC-656
|
# Conflicts: # GiniComponents/GiniInternalPaymentSDK/Sources/GiniInternalPaymentSDK/BanksView/BanksBottomView.swift # GiniComponents/GiniInternalPaymentSDK/Sources/GiniInternalPaymentSDK/PaymentInfo/PaymentInfoViewController.swift # GiniComponents/GiniInternalPaymentSDK/Sources/GiniInternalPaymentSDK/PaymentReviewContainer/PaymentReviewContainerView.swift IPC-651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains next tasks:
https://ginis.atlassian.net/browse/IPC-478 - Landscape Mode Payment Review Screen
https://ginis.atlassian.net/browse/IPC-464 - Landscape Mode Bank Selected Screen
https://ginis.atlassian.net/browse/IPC-474 - Landscape mode for Screen after GPC banking app is installed
https://ginis.atlassian.net/browse/IPC-481 - Landscape mode - Implement the "Share with" screen
https://ginis.atlassian.net/browse/IPC-468 - Landscape mode App store screen
https://ginis.atlassian.net/browse/IPC-484 - Landscape mode "More information" screen (FAQ)
https://ginis.atlassian.net/browse/IPC-457 - Landscape mode Bank selection screen (dropdown)
https://ginis.atlassian.net/browse/IPC-460 - Landscape mode Bank selection (Bank list)
https://ginis.atlassian.net/browse/IPC-519 - Reduce or eliminate the loading time when changing the orientation of the phone