8000 Avoid problematic toString no-ops by voltrevo · Pull Request #89 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Avoid problematic toString no-ops #89

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Avoid problematic toString no-ops #89

merged 3 commits into from
Jan 11, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Jan 11, 2022 •
edited
Loading

What is this PR doing?

Fixes the toString issue described previously.

Bonus:

  • Replaces @ethersproject imports that were missed earlier with the appropriate ethers direct imports

How can these changes be manually tested?

Run the new test that has been added.

Does this PR resolve or contribute to any issues?

Resolves #83.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@jacque006 jacque006 merged commit 2eaf374 into main Jan 11, 2022
@jacque006 jacque006 deleted the bw-83-avoid-toString-issue branch January 11, 2022 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid .toString issue
2 participants
@voltrevo @jacque006
0