8000 Deploy to arbitrum testnet by jzaki · Pull Request #79 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Deploy to arbitrum testnet #79

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Deploy to arbitrum testnet #79

merged 2 commits into from
Dec 30, 2021

Conversation

jzaki
Copy link
Collaborator
@jzaki jzaki commented Dec 30, 2021

What is this PR doing?

Logging deployed addresses

How can these changes be manually tested?

View contract addresses on testnet arbiscan

Does this PR resolve or contribute to any issues?

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@jzaki jzaki assigned jacque006 and unassigned jacque006 Dec 30, 2021
@github-actions github-actions bot added the contracts Smart contract related label Dec 30, 2021
@jzaki jzaki requested a review from jacque006 December 30, 2021 02:50
@github-actions github-actions bot added the aggregator Aggregator backend related label Dec 30, 2021
@voltrevo voltrevo force-pushed the deploy-testnet-contracts branch from 6ee5ae9 to 039b649 Compare December 30, 2021 07:06
@github-actions github-actions bot removed the aggregator Aggregator backend related label Dec 30, 2021
@voltrevo
Copy link
Collaborator

Force-push was reverting the commits I accidentally pushed that build on top of this branch but shouldn't be in this branch.

@@ -15,13 +17,14 @@ async function main() {
// If this script is run directly using `node` you may want to call compile
// manually to make sure everything is compiled
// await hre.run('compile');
const deployer = (await ethers.getSigners())[0];
const deployer = defaultDeployerWallet();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the old rinkarby.json and update the main README testnet setup instructions as well?

@jacque006 jacque006 merged commit c38c6f5 into main Dec 30, 2021
@jacque006 jacque006 deleted the deploy-testnet-contracts branch December 30, 2021 22:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contracts Smart contract related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0