10000 Add ability to blsWalletSigner to verify multiple addresses by JohnGuilding · Pull Request #600 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Add ability to blsWalletSigner to verify multiple addresses #600

Merged
merged 4 commits into from
May 9, 2023
Merged

Add ability to blsWalletSigner to verify multiple addresses #600

merged 4 commits into from
May 9, 2023

Conversation

JohnGuilding
Copy link
Collaborator
@JohnGuilding JohnGuilding commented May 4, 2023 •
edited
Loading

What is this PR doing?

  1. Fixes the blsWalletSigner.verify bug which means it cannot verify bundles with more than one address
  2. Updates the BundleService to use the updated API

How can these changes be manually tested?

  • Run new tests

Does this PR resolve or contribute to any issues?

Resolves #392

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@JohnGuilding JohnGuilding force-pushed the 392-blsWalletSigner-verify-cannot-verify-bundles-with-multiple-addresses branch from 93fd2f8 to 1dccccf Compare May 5, 2023 08:29
@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related contracts Smart contract related extension Browser extension related labels May 5, 2023
@JohnGuilding JohnGuilding force-pushed the 392-blsWalletSigner-verify-cannot-verify-bundles-with-multiple-addresses branch from 3b70254 to 1620721 Compare May 8, 2023 12:42
@JohnGuilding JohnGuilding marked this pull request as ready for review May 8, 2023 13:00
blakecduncan
blakecduncan approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor
@blakecduncan blakecduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JohnGuilding JohnGuilding merged commit 831632c into main May 9, 2023
@JohnGuilding JohnGuilding deleted the 392-blsWalletSigner-verify-cannot-verify-bundles-with-multiple-addresses branch May 9, 2023 10:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blakecduncan blakecduncan blakecduncan approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients contracts Smart contract related extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: blsWalletSigner.verify cannot verify bundles with multiple addresses
2 participants
@JohnGuilding @blakecduncan
0