8000 Fix fees on optimism by voltrevo · Pull Request #605 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Fix fees on optimism #605

Merged
merged 17 commits into from
Jun 27, 2023
Merged

Fix fees on optimism #605

merged 17 commits into from
Jun 27, 2023

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Jun 5, 2023 •
edited
Loading

What is this PR doing?

Fixes #602 using the optimism gas oracle and doing their custom L1 fee calculation.

How can these changes be manually tested?

Set BREAKEVEN_OPERATION_COUNT=2.5 and IS_OPTIMISM=true on optimism goerli. Run ./manualTests/mintNViaAggregator.ts 3 and verify that the aggregator makes a small profit.

Does this PR resolve or contribute to any issues?

Resolves #602.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the aggregator Aggregator backend related label Jun 5, 2023
@voltrevo voltrevo marked this pull request as ready for review June 5, 2023 08:59
jacque006
jacque006 reviewed Jun 27, 2023
View reviewed changes
Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change I will make, otherwise looks good

@jacque006
Move Optimism gas price oracle address to env file
823ec47 
Update docstrings & aggregator README.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 27, 2023
jacque006
jacque006 reviewed Jun 27, 2023
View reviewed changes
aggregator/.env.example

IS_OPTIMISM=false
OPTIMISM_GAS_PRICE_ORACLE_ADDRESS=0x420000000000000000000000000000000000000F
OPTIMISM_L1_BASE_FEE_PERCENT_INCREASE=2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voltrevo I used this default value based on PREVIOUS_BASE_FEE_PERCENT_INCREASE per docstring, let me know if we should use something else.

@jacque006 jacque006 merged commit abde552 into main Jun 27, 2023
@jacque006 jacque006 deleted the bw-602-fix-fees-on-optimism branch June 27, 2023 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

@blakecduncan blakecduncan Awaiting requested review from blakecduncan

@JohnGuilding JohnGuilding Awaiting requested review from JohnGuilding

Assignees
No one assigned
Labels
aggregator Aggregator backend related documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix estimateFee on optimism
2 participants
@voltrevo @jacque006
0