This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Clean up bls provider and signer #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- estimateGas test has an actual test in contract interaction tests
- list accounts is basically being tested in test below it (ethers logic just calls `.send("eth_accounts", [])`
- getBalance tested everywhere implicitly
f6ea284 to
c5d83f4
Compare
jacque006
approved these changes
May 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
signMessagemethodViewing the changes by each commit may make it easier to understand which tests were moved rather than deleted
How can these changes be manually tested?
Observing all tests pass
Does this PR resolve or contribute to any issues?
None
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors