This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Contracts connector #586
Merged
Contracts connector #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakecduncan
approved these changes
May 2, 2023
blakecduncan
reviewed
May 2, 2023
| static async create(signerOrProvider: SignerOrProvider) { | ||
| let provider: ethers.providers.Provider; | ||
|
|
||
| if ("getNetwork" in signerOrProvider) { |
There was a problem hiding this comment.
Any reason to not use ethers.providers.Provider.isProvider() here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestion
2DB7
s cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PR
This PR depends on #585.
After that's merged, toggle the target branch back and forth or push an empty commit to fix the diff. (Preview of this PR's changes.)
(If you want, you can also just review+merge this one directly. Github will automerge the previous PRs.)
What is this PR doing?
Adds a new utility
ContractsConnectorto bls-wallet-clients.Now that we use SafeSingletonFactory, there's no need to deal with configured addresses - instead you just connect to the contracts predetermined address (or throw an error if it's no there). The only problem is that you need the init data to figure out the address, and that init data can be another predetermined address. Our contracts are a small network of singletons that are initialized in a tree.
ContractsConnectoris just making this easy by dealing with the init data for you.How can these changes be manually tested?
yarn hardhat testDoes this PR resolve or contribute to any issues?
Contributes to #406.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors