Decode method name from encoded data when sending Tx #56
Conversation
|
confirmation box now displays actual method name |
There was a problem hiding this comment.
One optimization for address lookup, other changes look good.
One other note as we look at using functional React components. There are a number of optimizations you can do using useMemo & useCallback to reduce re-renders. https://www.backtofrontend.com/react-optimizations-memo-usecallback-usememo/ does a very good job of highlighting some basic cases. There would be some good uses for these especially for the useInputDecode hook, but might be overkill at this point. If you're interested in trying those out, I'd be happy to show you offline :)
Yeah Agreed, however each trigger creates a new self-contained window (with independent states) and the state is set once (default -> final) via url params. Since the state does not depend on any other interaction it wont change at all and the window will only be rendered once. So I guess for now memoization might not be needed here. WDYT? |
|
In that case the memoization is likely a premature optimization. Can revisit when/if that hook is used in other places in the future. |
What is this PR doing?
How can these changes be manually tested?
yarnPROVIDER_URL= alchemy/infura endpoint for mainnet andETHERSCAN_KEY= currently unusedENV=local yarn run dev:chromeand import extension as a package inside chromeDoes this PR resolve or contribute to any issues?
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors