8000 `tx.origin` payments in fallback expander by voltrevo · Pull Request #558 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

tx.origin payments in fallback expander #558

Merged
merged 2 commits into from
Mar 28, 2023
Merged

tx.origin payments in fallback expander #558

merged 2 commits into from
Mar 28, 2023

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Mar 16, 2023 •
edited
Loading

Dependent PR

These PR(s) should be merged first:

What is this PR doing?

Enables optimized tx.origin payments in the fallback expander:

  • Use the bit stream to encode whether an optimized tx.origin payment is included (usually 0 bytes added, but can add 1 byte if you have many actions and are unlucky)
  • If that bit is set, read a pseudofloat at the end of the regular actions and pay tx.origin that amount using the stored address for AggregatorUtilities

(That means the expected cost to add a tx.origin payment is 2 bytes. Just make sure you keep the precision to 3 significant figures.)

How can these changes be manually tested?

yarn hardhat test

Does this PR resolve or contribute to any issues?

Resolves #554.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added clients contracts Smart contract related labels Mar 16, 2023
@voltrevo voltrevo changed the base branch from contract-updates to main March 17, 2023 00:39
@voltrevo voltrevo changed the base branch from main to contract-updates March 17, 2023 00:39
@jacque006 jacque006 changed the base branch from contract-updates to main March 28, 2023 02:39
@jacque006 jacque006 changed the base branch from main to contract-updates March 28, 2023 02:39
@jacque006 jacque006 merged commit 4c9c0ed into contract-updates Mar 28, 2023
@jacque006 jacque006 deleted the bw-554-fallback-tx-origin branch March 28, 2023 02:40
@jacque006 jacque006 mentioned this pull request Mar 28, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
clients compression contracts Smart contract related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @jacque006
0