8000 Add expander for registration by voltrevo · Pull Request #555 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Add expander for registration #555

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Add expander for registration #555

merged 10 commits into from
Mar 17, 2023

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Mar 15, 2023 •
edited
Loading

What is this PR doing?

  • Adds BLSRegistration.sol
    • Both an expander and supplies the .register method so it can use msg.sender for the address
  • Adds compressor BlsRegistrationCompressor
  • Adds tests with detailed explanations of actual compressed data sent to BLSExpanderDelegator.run

How can these changes be manually tested?

yarn hardhat test

(Search 'registration' in expander-test.ts for relevant new tests.)

Does this PR resolve or contribute to any issues?

Resolves #525

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added clients contracts Smart contract related labels Mar 15, 2023
@voltrevo voltrevo force-pushed the bw-525-registration branch from c5a262e to 96c61e9 Compare March 15, 2023 06:45
@voltrevo voltrevo mentioned this pull request Mar 15, 2023
Merged
2 tasks
jacque006
jacque006 suggested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking issue I see is license change.

I personally prefer using Unlicense, but most of our groups projects use MIT I imagine for some specific legal reason.

jacque006
jacque006 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License matches existing contracts, fine as is #555 (comment)

@jacque006 jacque006 merged commit fdf80fc into contract-updates Mar 17, 2023
@jacque006 jacque006 deleted the bw-525-registration branch March 17, 2023 00:07
@jacque006 jacque006 mentioned this pull request Mar 28, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
clients compression contracts Smart contract related
Projects
447C
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @jacque006
0