This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Use BLSWallet and ProxyAdmin directly inside VerificationGateway #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b38a7f3 to
af420d9
Compare
2 tasks
jzaki
approved these changes
Mar 1, 2023
Base automatically changed from
bw-394-use-safe-singleton-factory
to
contract-updates
March 2, 2023 09:10
|
Not sure why the aggregator and integration tests ran previously. This PR shouldn't be triggering them / those tests failing is expected. Bumping seems to have fixed it 🤷♂️. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PR
This PR builds on top of #464. To reduce confusion, please either merge that PR first or retarget this branch to
contract-updatesto make it one PR that contains everything.What is this PR doing?
With the revelation that the 30m gas limit issue is a hardhat testing bug (which doesn't affect this branch) and that we therefore have plenty of headroom, this PR uses
BLSWalletandProxyAdmindirectly insideVerificationGateway.This reduces complexity, removes the
ProxyAdminGeneratorworkaround entirely.VerificationGatewaynow deploys with 4,798,984, so we still have 25m gas of headroom.We could also set
runs: 1000in the optimization settings, but it looks like the gas used by an operation actually goes up by doing that, so I've left it alone.How can these changes be manually tested?
yarn testDoes this PR resolve or contribute to any issues?
Contributes to #394.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors