This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Merge from main + fix #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add alea lib for deterministic random values Move gas scripts to new folder Move to config based approach for measurement script Fix bls wallet lazy creation in fixture so nonce will be correct for larger amount of wallets Fix fixture initialization of bls wallet contract from swallowing errors & attempting to initialize when not needed. Get arbitrum specific gas field Add address indexing optimization to expander, better typing on contracts fixture Use @ethereumjs/tx to get raw txn size Add sleep between measurements Add local Ci test to make sure measurement script is working Update measurements to be able to handle multiple transactions Update gethDev to allow for longer http timeouts on longer running operations
Add gas measurement README. Add BLS Wallet & EOA signer addresses to results. Split gas measurement index into run & measurement files. Minor code cleanup & bug fixes.
Add BLSWalletContracts and connectToContracts to clients to make it easier to bootstrap contracts. Simplify gas measurement config to rely on netowrk config. Use token minting instead of transfers. Add processBundle utility with error checking. Use a custom ethers.js provider and signer to better handle RPC throttling/rate limiting. Remove sleep between transaction config runs.
…ovements Integrations documentation improvements
Remove arbitrum measurements if no l1Gas prop found.
Switch to sqlite
Publish aggregator images using CI
Fix docs typos
Co-authored-by: Andrew Morris <voltrevo@gmail.com>
Update gas measurement script for Arbitrum Nitro
Sqlite followup
…tests Use geth in client integration tests
7186d86 to
e2b0b77
Compare
e2b0b77 to
2b57673
Compare
de0411a to
e1e654e
Compare
|
I didn't actually press the merge button without review! 😅 What I did do was merge in the changes from main, do some post-merge fixes, and push to contract-updates. I did this with this testing PR open and pushing contract-updates made github consider this to be merged. Arguably we should actually be doing PRs for merging and getting them reviewed since they can contain discretionary changes from resolving conflicts. Was trying to avoid confusion. Hit me up if you're confused, sorry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
How can these changes be manually tested?
Does this PR resolve or contribute to any issues?
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors