This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Change port to --net=host in startup script #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakecduncan
commented
Jan 20, 2023
| @@ -36,7 +36,7 @@ echo "Creating $CONTAINER_NAME using $IMAGE_NAME" | |||
| docker run \ | |||
| --name "$CONTAINER_NAME" \ | |||
| -d \ | |||
| -p$PORT:$PORT \ | |||
| --net=host | |||
There was a problem hiding this comment.
This change and setting PG_HOST=127.0.0.1 in the env vars fixed my issue
voltrevo
approved these changes
Jan 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
I was trying to update the optimism aggregator with the latest changes in main. Two big things included my change to add a status column and the change to take the env vars out of the docker image.
I noticed when starting up the container with the the new start-docker script that the aggregator was failing to connect to postgres. I had to make this change and I also had to change the PG_HOST to
PG_HOST=127.0.0.1instead of using localhost. I got the idea about the PG_HOST from this thread. Not sure why it wasn't working before.How can these changes be manually tested?
Build a docker image and try to start it up
Does this PR resolve or contribute to any issues?
No
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors