8000 Fix issue with fetch in client in browser by jacque006 · Pull Request #431 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Fix issue with fetch in client in browser #431

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Fix issue with fetch in client in browser #431

merged 3 commits into from
Dec 23, 2022

Conversation

jacque006
Copy link
Collaborator

What is this PR doing?

  • Bind fetch function to window/global scope to prevent the below:

image

  • Use fetchResponse.text() instead of ,json() to handle empty responses without a JSON parsing error.

How can these changes be manually tested?

Does this PR resolve or contribute to any issues?

No

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related extension Browser extension related labels Dec 23, 2022
@jacque006 jacque006 merged commit 8fa6b50 into main Dec 23, 2022
@jacque006 jacque006 deleted the bug/agg-client-fetch-error branch December 23, 2022 19:10
@jacque006 jacque006 mentioned this pull request Dec 23, 2022
Closed
2 tasks
@jacque006 jacque006 mentioned this pull request Jan 24, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JohnGuilding JohnGuilding JohnGuilding approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacque006 @JohnGuilding
0