8000 Charge accurate fees -- followup by voltrevo · Pull Request #438 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Charge accurate fees -- followup #438

Merged
merged 6 commits into from
Jan 6, 2023
Merged

Charge accurate fees -- followup #438

merged 6 commits into from
Jan 6, 2023

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Jan 6, 2023 •
edited
Loading

What is this PR doing?

  • Add new environment variables in README.md
  • Document fee system in README.md
  • Add some code comments
  • Split out baseFeeIncrease calculation

How can these changes be manually tested?

NA (tests I suppose, covered by PR automation)

Does this PR resolve or contribute to any issues?

Nope.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related documentation Improvements or additions to documentation labels Jan 6, 2023
@voltrevo voltrevo mentioned this pull request Jan 6, 2023
Merged
2 tasks
@voltrevo voltrevo marked this pull request as ready for review January 6, 2023 06:03
blakecduncan
blakecduncan approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor
@blakecduncan blakecduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

aggregator/src/app/EthereumService.ts
@@ -368,11 +368,24 @@ export default class EthereumService {
const previousBaseFee = block.baseFeePerGas;
assert(previousBaseFee !== null && previousBaseFee !== nil);

// Increase the basefee we're willing to pay to improve the chance of our
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this makes a lot of sense 💯

@blakecduncan blakecduncan merged commit 2e2b4f3 into main Jan 6, 2023
@blakecduncan blakecduncan deleted the bw-415-followup branch January 6, 2023 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blakecduncan blakecduncan blakecduncan approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @blakecduncan
0