8000 Fix encodedFunction type and update client pins by voltrevo · Pull Request #397 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Fix encodedFunction type and update client pins #397

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix encodedFunction type and update client pins #397

merged 2 commits into from
Nov 14, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Nov 14, 2022 •
edited
Loading

What is this PR doing?

  • Fixes type of ActionData.encodedFunction
  • Updates pinned versions of bls-wallet-clients (unlike this similar recent PR, a new deployment was not needed because the contracts haven't changed)

When typechain was updated, we had to switch from the inferred type of Operation to our explicit types, which meant that ActionData.encodedFunction went from BytesLike to string.

This caused the following code to break:
https://github.com/web3well/bls-wallet/blob/02298b8/aggregator/test/EthereumService.test.ts#L247

And in general, BytesLike is a better interface since it also allows the user to use Uint8Array (as well as strings beginning with 0x).

How can these changes be manually tested?

  • Test EthereumService.test.ts
  • Run aggregator+extension and do a transfer

Does this PR resolve or contribute to any issues?

Resolves #396.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients extension Browser extension related labels Nov 14, 2022
@jacque006 jacque006 merged commit 57e7ec3 into contract-updates Nov 14, 2022
@jacque006 jacque006 deleted the update-client-pins-again branch November 14, 2022 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @jacque006
0