8000 Update dependencies by voltrevo · Pull Request #368 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Update dependencies #368

Merged
merged 8 commits into from
Nov 10, 2022
Merged

Update dependencies #368

merged 8 commits into from
Nov 10, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Nov 1, 2022

What is this PR doing?

Updates dependencies for contracts, contracts/clients.

How can these changes be manually tested?

contracts:
yarn test

contracts/clients:
yarn build && yarn test

Does this PR resolve or contribute to any issues?

Resolves #160.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added clients contracts Smart contract related automation CI/CD related labels Nov 1, 2022
Copy link
Contributor
@blakecduncan blakecduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - just one non-blocking comment

@@ -1,3 +1,5 @@
/* eslint-disable camelcase */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - If we disable this rule for the file we could remove the disables on the individual lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voltrevo voltrevo merged commit 59e1a65 into contract-updates Nov 10, 2022
@voltrevo voltrevo deleted the bw-160-update-deps branch November 10, 2022 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD related clients contracts Smart contract related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0