8000 Fix issue getting existing wallet addresses by jacque006 · Pull Request #340 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Fix issue getting existing wallet addresses #340

Closed
wants to merge 7 commits into from
Closed

Fix issue getting existing wallet addresses #340

wants to merge 7 commits into from

Conversation

jacque006
Copy link
Collaborator
@jacque006 jacque006 commented Sep 15, 2022 •
edited
Loading

What is this PR doing?

  • Update BlsWalletWrapper.Address() to check for existing wallet address from the VerifiicationGateway before calculating the CREATE2 address for a new wallet from a given private key.
  • Throw an exception in BlsWalletWrapper.connect & Address if a wallet recovery is detected.
  • Add sendEth Hardhat utility task , remove old send_eth script.

How can these changes be manually tested?

  • Check BlsWalletWrapper.Address() for a wallet after recovering to a new public key
  • Send some eth using the sendEth task.

Does this PR resolve or contribute to any issues?

No

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@jacque006
Fix issue with exisiting wallet addresses
2790596 
Update BlsWalletWrapper.Address() to check for existing wallet address from the VerifiicationGateway before calculating the CREATE2 address for a new wallet from a given private key.
@github-actions github-actions bot added aggregator Aggregator backend related aggregator-proxy Aggregator proxy related contracts Smart contract related extension Browser extension related labels Sep 15, 2022
@jacque006 jacque006 changed the title Fix issue with exisiting wallet addresses Fix issue with existing wallet addresses Sep 15, 2022
@jacque006 jacque006 changed the title Fix issue with existing wallet addresses Fix issue getting existing wallet addresses Sep 15, 2022
@jzaki
Copy link
Collaborator
jzaki commented Sep 15, 2022

I spoke with Blake about this, and the fix is in the branch I'm working on, there's still another issue around this I'll be resolving too.

@jzaki jzaki mentioned this pull request Oct 4, 2022
Merged
2 tasks
@jacque006
Copy link
Collaborator Author

Will update & re-evaluate this once #350 is merged to main

@jacque006 jacque006 mentioned this pull request Oct 27, 2022
Merged
14 tasks
@jacque006
Copy link
Collaborator Author

Integrated into #367

Closing in favor of that branch & PR

@jacque006 jacque006 closed this Oct 27, 2022
@jacque006 jacque006 deleted the bug/recovery-address branch October 27, 2022 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@voltrevo voltrevo voltrevo approved these changes

@jzaki jzaki Awaiting requested review from jzaki

@kautukkundan kautukkundan Awaiting requested review from kautukkundan

@blakecduncan blakecduncan Awaiting requested review from b 60FD lakecduncan

@JohnGuilding JohnGuilding Awaiting requested review from JohnGuilding

Assignees
No one assigned
Labels
aggregator Aggregator backend related aggregator-proxy Aggregator proxy related clients contracts Smart contract related extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacque006 @jzaki @voltrevo
0