8000 Switch to supported contracts when testing aggregator by voltrevo · Pull Request #313 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Switch to supported contracts when testing aggregator #313

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Sep 1, 2022

What is this PR doing?

See title.

This is the same strategy advised in our local testing guide. We should revise this when we start cutting releases as described in #295 (comment).

How can these changes be manually tested?

Ensure the automated PR test passes for the aggregator tests.

Does this PR resolve or contribute to any issues?

Resolves #271.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the automation CI/CD related label Sep 1, 2022
@voltrevo voltrevo marked this pull request as ready for review September 1, 2022 03:37
@voltrevo voltrevo marked this pull request as draft September 1, 2022 03:42
@voltrevo voltrevo marked this pull request as ready for review September 1, 2022 03:59
Copy link
Contributor
@blakecduncan blakecduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@voltrevo voltrevo merged commit 6f45f79 into main Sep 2, 2022
@voltrevo voltrevo deleted the bw-271-fix-aggregator-tests branch September 2, 2022 00:13
@voltrevo voltrevo mentioned this pull request Sep 8, 2022
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix aggregator test failures
2 participants
0