8000 When wrapping className, use one class per line by voltrevo · Pull Request #275 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

When wrapping className, use one class per line #275

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Jul 19, 2022

What is this PR doing?

Followup for #267 (comment).

I haven't included classNames that don't require any wrapping, since that seems very unlikely to be maintained going forward and is probably overkill. If only className was just an array 😵.

How can these changes be manually tested?

Check the UI looks normal. (No visible changes intended).

Does this PR resolve or contribute to any issues?

Resolves #272.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the extension Browser extension related label Jul 19, 2022
@jacque006 jacque006 merged commit 0570216 into main Jul 20, 2022
@jacque006 jacque006 deleted the one-class-per-line branch July 20, 2022 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extension Browser extension related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followup about className formatting
2 participants
0