8000 Fixes: one-to-one hash wallet by jzaki · Pull Request #212 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Fixes: one-to-one hash wallet #212

Merged
merged 8 commits into from
Jun 19, 2022
Merged

Fixes: one-to-one hash wallet #212

merged 8 commits into from
Jun 19, 2022

Conversation

jzaki
Copy link
Collaborator
@jzaki jzaki commented May 31, 2022 •
edited by kautukkundan
Loading

What is this PR doing?

Ensuring a wallet only has one bls key registered for it.

How can these changes be manually tested?

@kautukkundan can you write a test for this?

Does this PR resolve or contribute to any issues?

Fixes #104

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added the contracts Smart contract related label May 31, 2022
jacque006
jacque006 reviewed Jun 1, 2022
View reviewed changes
Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall core changes look good 👍

@kautukkundan kautukkundan mentioned this pull request Jun 6, 2022
Closed
2 tasks
@kautukkundan kautukkundan force-pushed the feat/one-to-one-hash-wallet branch from 1db6039 to fdd1c02 Compare June 14, 2022 18:15
@kautukkundan kautukkundan marked this pull request as ready for review June 14, 2022 18:16
@voltrevo
Copy link
Collaborator

@jzaki @jacque006 I think we should generally be merging things as soon as we approve them rather than giving it back to the author to decide. Or maybe we need to talk about this policy?

(Is there a reason why this one wasn't merged last week?)

@jzaki
Copy link
Collaborator Author
jzaki commented Jun 19, 2022 •
edited
Loading

@voltrevo There are some things that have surfaced in my review that I'm in the process of addressing. Can share details once complete.

@jzaki jzaki force-pushed the feat/one-to-one-hash-wallet branch from c6480ae to 4dae24f Compare June 19, 2022 16:52
@jzaki jzaki merged commit ce7f958 into main Jun 19, 2022
@jzaki jzaki deleted the feat/one-to-one-hash-wallet branch June 19, 2022 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kautukkundan kautukkundan kautukkundan left review comments

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
contracts Smart contract related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2. Multiple BLS keys can be registered for each smart contract wallet
4 participants
@jzaki @voltrevo @jacque006 @kautukkundan
0