8000 Arbitrum testnet update by voltrevo · Pull Request #196 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Arbitrum testnet update #196

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Arbitrum testnet update #196

merged 4 commits into from
Apr 22, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Apr 22, 2022 •
edited
Loading

What is this PR doing?

Records the addresses of new arbitrum testnet deployment

Also:

  • Comments out some code in an aggregator manual test that isn't working properly
    • (Should be fixed instead but not introduced here so should be fixed separately)
  • Adds some logging in Create2Fixture

How can these changes be manually tested?

  • Inspect the addresses using https://testnet.arbiscan.io/
  • Run an aggregator pointing to arbitrum testnet and these addresses, run manualTests/mint1ViaAggregator.ts and confirm mint works successfully

Does this PR resolve or contribute to any issues?

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related contracts Smart contract related labels Apr 22, 2022
jacque006
jacque006 approved these changes Apr 22, 2022
View reviewed changes
contracts/shared/helpers/Create2Fixture.ts
Comment on lines +90 to +96
console.log(
[
`Deployed ${contractName}`,
`using ${receipt.gasUsed.toString()} gas:`,
contractAddress,
].join(" "),
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to pass this in as one formatted string or as a comma separated list and let the CLI output format it depending on terminal width. Reason you wanted to use this specific format?

@jacque006 jacque006 merged commit 5a89933 into main Apr 22, 2022
@jacque006 jacque006 deleted the arbitrum-testnet-update branch April 22, 2022 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related contracts Smart contract related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @jacque006
0