8000 Add receipts by voltrevo · Pull Request #186 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Add receipts #186

Merged
merged 21 commits into from
Apr 15, 2022
Merged

Add receipts #186

merged 21 commits into from
Apr 15, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Apr 8, 2022 •
edited
Loading

What is this PR doing?

Screen.Recording.2022-04-08.at.8.48.06.pm.mov

(I forgot to refresh the page to show the billboard is successfully updated. It does work though 😄.)

  • Adds support for transaction receipts when using extension+aggregator
  • Uses random ids (instead of autoincrement) for the primary key of the bundles table, which is better suited as a stand-in for transactionHash. It also simplifies things a bit since we don't need to rely on the database to generate the ids for us, and so BundleRow["id"] is no longer optional.
  • Changes the response to POST /bundle to include the row id on successful insertion
  • Removes old background script replaced by Chai's work

How can these changes be manually tested?

Replicate the result shown in the video. This requires running:

  • Local node
  • Deploying contracts
  • Deploying billboard
  • Aggregator

Note that the billboard uses the block timestamp to determine whether it's ok to set it to a new value. This can cause issues in the aggregator because callStatic won't see the new timestamp and won't submit the bundle until it does. This isn't a big deal on a real network with a constant flow of transactions, but to resolve it locally, just add an artificial transaction, such as by running aggregator/manualTests/send1Wei.ts.

Does this PR resolve or contribute to any issues?

#178, #179

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related clients contracts Smart contract related extension Browser extension related labels Apr 8, 2022
@voltrevo voltrevo marked this pull request as ready for review April 8, 2022 10:59
jacque006
jacque006 reviewed Apr 11, 2022
View reviewed changes
Copy link
Collaborator
@jacque006 jacque006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall solid work getting this functionality baked in. I think there is a good amount of discovered work/new issues from this and a few things we can try to tweak now.

@jacque006 jacque006 merged commit 3dcae29 into main Apr 15, 2022
@jacque006 jacque006 deleted the add-receipts branch April 15, 2022 13:09
This was referenced Apr 15, 2022
Merged
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacque006 jacque006 jacque006 approved these changes

Assignees
No one assigned
Labels
aggregator Aggregator backend related clients contracts Smart contract related extension Browser extension related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voltrevo @jacque006
0