This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Use BigNumber for nonces #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Switches to storing nonces as
BigNumberin EthereumService, since that's the only place we were still usingnumber. I think I mostly already fixed this when doing the bundle conversion.Turns out we're already relying on
wallet.getTransactionCount()from ethers which usesnumber, so... that's a bit awkward. I did some quick math though and if tx fees are as low as 1 cent then you still have to go through $trillions in fees before exhausting the safe integer range ofnumber. Let's just assume that in such a scenario the organization running the affected aggregator would have the resources to deal with the problem before it happens :).How can these changes be manually tested?
Run the premerge script.
Does this PR resolve or contribute to any issues?
Resolves #10.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors